[ 
https://issues.apache.org/jira/browse/FLINK-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177390#comment-15177390
 ] 

ASF GitHub Bot commented on FLINK-3474:
---------------------------------------

Github user ChengXiangLi commented on the pull request:

    https://github.com/apache/flink/pull/1746#issuecomment-191621309
  
    Hi, @fhueske , i found 2 test failure due to the input data of 
`AggregateMapFunction` is `Tuple` instead of `Row` while table config is 
`EFFICIENT`. I thought `Tuple` as other types are only supported as data 
source, inside SQL operators only support `Row`. Why this is introduced? more 
efficient? I thought the road map would go to Row which store binary data.


> Partial aggregate interface design and sort-based implementation
> ----------------------------------------------------------------
>
>                 Key: FLINK-3474
>                 URL: https://issues.apache.org/jira/browse/FLINK-3474
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API
>            Reporter: Chengxiang Li
>            Assignee: Chengxiang Li
>
> The scope of this sub task includes:
> # Partial aggregate interface.
> # Simple aggregate function implementation, such as SUM/AVG/COUNT/MIN/MAX.
> # DataSetAggregateRule which translate logical calcite aggregate node to 
> Flink user functions. As hash-based combiner is not available yet(see PR 
> #1517), we would use sort-based combine as default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to