[GitHub] [flink] rmetzger commented on a change in pull request #14251: [FLINK-20382][runtime] Fail hard when JobMaster cannot start scheduling of a job

[GitBox]

rmetzger commented on a change in pull request #14251:
URL: https://github.com/apache/flink/pull/14251#discussion_r531634427



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/util/FatalExitExceptionHandler.java
##########
@@ -32,6 +32,7 @@
        private static final Logger LOG = 
LoggerFactory.getLogger(FatalExitExceptionHandler.class);
 
        public static final FatalExitExceptionHandler INSTANCE = new 
FatalExitExceptionHandler();
+       public static final int EXIT_CODE = -17;

Review comment:
       Since you are touching this already: I would propose to use a different 
exit code for the fatal exit code handler than here: 
https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/util/JvmShutdownSafeguard.java#L44
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org