tillrohrmann commented on a change in pull request #14251:
URL: https://github.com/apache/flink/pull/14251#discussion_r531718698



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
##########
@@ -932,7 +932,7 @@ private void resetAndStartScheduler() throws Exception {
                        );
                }
 
-               schedulerAssignedFuture.thenRun(this::startScheduling);
+               
FutureUtils.assertNoException(schedulerAssignedFuture.thenRun(this::startScheduling));

Review comment:
       The intention of this PR is to fix the problem of swallowed exceptions 
and not the job lifecycle management based on operator coordinator failures. I 
don't know whether restarting a job makes sense if the operator coordinator has 
failed to start. To me it looks as if the operator coordinator integration 
hasn't been completed yet. I would consider this as a follow up task.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to