wangxlong commented on a change in pull request #14280:
URL: https://github.com/apache/flink/pull/14280#discussion_r547294770
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/functions/aggfunctions/FirstValueAggFunction.java
##########
@@ -83,7 +83,7 @@ public void accumulate(RowData rowData, Object value) {
GenericRowData acc = (GenericRowData) rowData;
if (value != null && acc.getLong(1) == Long.MAX_VALUE) {
acc.setField(0, value);
- acc.setField(1, System.currentTimeMillis());
+ acc.setField(1, System.nanoTime());
Review comment:
I prefer the higher precision of nanoTime, for we use this as the order
when merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
