wangxlong commented on a change in pull request #14280:
URL: https://github.com/apache/flink/pull/14280#discussion_r547299348
##########
File path:
flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/functions/aggfunctions/AggFunctionTestBase.java
##########
@@ -100,15 +100,15 @@ public void testAggregateWithMerge()
List<T> inputValues = inputValueSets.get(i);
T expected = expectedResults.get(i);
// equally split the vals sequence into two
sequences
- Tuple2<List<T>, List<T>> splitValues =
splitValues(inputValues);
+ Tuple2<List, List> splitValues =
splitValues(inputValues);
List<T> firstValues = splitValues.f0;
List<T> secondValues = splitValues.f1;
+
// 1. verify merge with accumulate
+ ACC acc = accumulateValues(firstValues);
List<ACC> accumulators = new ArrayList<>();
accumulators.add(accumulateValues(secondValues));
- ACC acc = accumulateValues(firstValues);
-
Review comment:
I update I modified it because we need to split valueList which type is
`T`, and we also need to split orderList which type is `Long`. I think it
should be the same because of type erasure.
But it's really not elegant, or we can use `Object` type for list element
for splitValues method？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
