curcur commented on a change in pull request #14567:
URL: https://github.com/apache/flink/pull/14567#discussion_r555008866
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -26,7 +26,14 @@
import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
import org.apache.flink.streaming.api.graph.StreamConfig;
import org.apache.flink.streaming.api.operators.MailboxExecutor;
-import org.apache.flink.streaming.runtime.tasks.SubtaskCheckpointCoordinator;
+import
org.apache.flink.streaming.runtime.tasks.checkpointing.AlignedController;
+import
org.apache.flink.streaming.runtime.tasks.checkpointing.AlternatingController;
+import
org.apache.flink.streaming.runtime.tasks.checkpointing.CheckpointBarrierBehaviourController;
Review comment:
I am fine with either way, but the following explains some of the
considerations why they are put in the current way.
`CheckpointedInputGate` is overall an input gate (but just a different type
of input gate), that's why I left it in .....runtime.io
`InputProcessorUtil` is mostly createXXXCheckpointedInputGate, that's why I
left it with "CheckpointedInputGate"
`UpstreamRecoveryTracker` is channel recovery-related, and that's why I put
within .....runtime.io as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
