curcur commented on a change in pull request #14567:
URL: https://github.com/apache/flink/pull/14567#discussion_r555054059
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -26,7 +26,14 @@
import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
import org.apache.flink.streaming.api.graph.StreamConfig;
import org.apache.flink.streaming.api.operators.MailboxExecutor;
-import org.apache.flink.streaming.runtime.tasks.SubtaskCheckpointCoordinator;
+import
org.apache.flink.streaming.runtime.tasks.checkpointing.AlignedController;
+import
org.apache.flink.streaming.runtime.tasks.checkpointing.AlternatingController;
+import
org.apache.flink.streaming.runtime.tasks.checkpointing.CheckpointBarrierBehaviourController;
Review comment:
@pnowojski
Copied my explanation from the Jira ticket why these classes are moved to
the package named this way:
If we do not move SubtaskCheckpointCoordinator(Impl), I think
`org.apache.flink.streaming.runtime.checkpointing` is a good choice.
But if we want to move SubtaskCheckpointCoordinator(Impl) together with the
above seven classes, I would lean to
`org.apache.flink.streaming.runtime.tasks.checkpointing`.
I think it is a good idea to put all checkpointing related classes
altogether, so I prefer
`org.apache.flink.streaming.runtime.tasks.checkpointing` as a result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
