[ 
https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271805#comment-17271805
 ] 

Jark Wu commented on FLINK-21045:
---------------------------------

Thanks [~qingyue] for the investigation. 

1) Is "WITH" necessary?
I went througth the long discusision [1] on mailing list again, and I think the 
WITH clause is necessary.
The framework doesn't remember the mapping of name and module properties, so 
it's necessary to carry with the properties when loading a module. 

2) "RELOAD MODULE X" vs "LOAD MODULE X"
It's hard to use RELOAD MODULE to change the order of modules. The previous 
discussion [1] also proposed "USE MODULES X, Y, Z" to reoder modules.
However, it was rejected for simplicity and concise API.

3) SHOW MODULES
Yes, I believe we should support SHOW MODULES too. 

[1]: https://www.mail-archive.com/dev@flink.apache.org/msg29894.html

> Support 'load module' and 'unload module' SQL syntax
> ----------------------------------------------------
>
>                 Key: FLINK-21045
>                 URL: https://issues.apache.org/jira/browse/FLINK-21045
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Planner
>    Affects Versions: 1.13.0
>            Reporter: Nicholas Jiang
>            Assignee: Jane Chan
>            Priority: Major
>             Fix For: 1.13.0
>
>
> At present, Flink SQL doesn't support the 'load module' and 'unload module' 
> SQL syntax. It's necessary for uses in the situation that users load and 
> unload user-defined module through table api or sql client.
> SQL syntax has been proposed in FLIP-68: 
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-68%3A+Extend+Core+Table+System+with+Pluggable+Modules



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to