[ 
https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272878#comment-17272878
 ] 

Timo Walther commented on FLINK-21045:
--------------------------------------

Thanks for discussing this topic again. I quickly scanned the old discussion. 
On one hand CREATE/DROP MODULE would definitely be more consistent. However, 
the big difference to all other objects like catalogs, functions, and tables is 
that actually the name is not used for resolution in queries. Instead, the 
order of modules is an important property. I would like to hear other opinions, 
personally I would rather stick to the agreed design. Because loading/unloading 
modules is a concept known from kernels etc. And defining the order of modules 
sounds like a very specific use case that regular users should not worry about.

Regarding modules in general, I think we should also update this architecture a 
bit. Shall we call the property {{module = 'hive'}} to be consistent with the 
new property design? In any case, we should also update to `Factory` instead of 
the deprecated `TableFactory` stack.

> Support 'load module' and 'unload module' SQL syntax
> ----------------------------------------------------
>
>                 Key: FLINK-21045
>                 URL: https://issues.apache.org/jira/browse/FLINK-21045
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Planner
>    Affects Versions: 1.13.0
>            Reporter: Nicholas Jiang
>            Assignee: Jane Chan
>            Priority: Major
>             Fix For: 1.13.0
>
>
> At present, Flink SQL doesn't support the 'load module' and 'unload module' 
> SQL syntax. It's necessary for uses in the situation that users load and 
> unload user-defined module through table api or sql client.
> SQL syntax has been proposed in FLIP-68: 
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-68%3A+Extend+Core+Table+System+with+Pluggable+Modules



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to