rmetzger commented on a change in pull request #14767:
URL: https://github.com/apache/flink/pull/14767#discussion_r565337043
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/runtime/BlockingShuffleITCase.java
##########
@@ -94,6 +95,7 @@ private JobGraph createJobGraph(int numRecordsToSend) {
StreamGraph streamGraph = env.getStreamGraph();
streamGraph.setGlobalDataExchangeMode(GlobalDataExchangeMode.ALL_EDGES_BLOCKING);
streamGraph.setScheduleMode(ScheduleMode.LAZY_FROM_SOURCES);
+ streamGraph.setJobType(JobType.BATCH);
Review comment:
I'm not sure if implicitly setting the job type is a good idea: How
would you handle conflicting job types (e.g. StreamGraph.jobType = Streaming +
StreamGraph.globalDataExchange = BLOCKING).
If we see that a lot more tests require setting the job type manually, then
I'd revisit this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
