guoweiM commented on a change in pull request #14734:
URL: https://github.com/apache/flink/pull/14734#discussion_r567541421
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -563,7 +554,7 @@ private void
startTriggeringCheckpoint(CheckpointTriggerRequest request) {
createPendingCheckpoint(
timestamp,
request.props,
- ackTasks,
+ checkpointBrief,
Review comment:
What I understand is that the `CheckpointBrief` describes how to “get” a
`CompleteChekcpoint`. There are some methods related to“get”a
CompleteCheckpoint, such as
“createPendingCheckpoint/reportToStateTracker/sendAbortedMessage/sendAcknowledgeMessages”.
However, these methods sometime use `CheckpointBrief`, sometime uses
`tasksTowaitFor/tasksToTriggerFor`, which are the internal state of the
`CheckpointCoordinator`. After we refactor maybe all the methods could only use
the `CheckpointBrief` as their parameter. (I think CheckpointId,TimeStamps
should also be in the CheckpointBrief).
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
