[ 
https://issues.apache.org/jira/browse/FLINK-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283680#comment-17283680
 ] 

Kezhu Wang commented on FLINK-20580:
------------------------------------

I am kind of prefer third option.

If we allow nullable value in {{SerializedValue(T value)}}, then 
{{SerializedValue.deserializeValue}} will be nullabe, while we all know that it 
is almost always not null. But when that happens, it may be too far from its 
cause.

> Missing null value handling for SerializedValue's getByteArray() 
> -----------------------------------------------------------------
>
>                 Key: FLINK-20580
>                 URL: https://issues.apache.org/jira/browse/FLINK-20580
>             Project: Flink
>          Issue Type: Bug
>          Components: API / Type Serialization System
>    Affects Versions: 1.13.0
>            Reporter: Matthias
>            Assignee: Kezhu Wang
>            Priority: Minor
>              Labels: pull-request-available, starter
>
> {{SerializedValue}} allows to wrap {{null}} values. Because of this, 
> {{SerializedValue.getByteArray()}} might return {{null}} which is not 
> properly handled in different locations (it's probably the best to use the 
> IDEs "Find usages" to identify these locations). The most recent findings 
> (for now) are listed in the comments.
> We should add null handling in these cases and add tests for these cases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to