[ 
https://issues.apache.org/jira/browse/FLINK-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283726#comment-17283726
 ] 

Kezhu Wang commented on FLINK-20580:
------------------------------------

{quote}
If we want to support null values, then returning an empty byte[] does not work 
because it would not deserialize to null. This would be somewhat surprising 
given that SerializedValue.getByteArray should return the bytes of the 
serialized value.
{quote}

Yeh, a bit surprising for {{SerializedValue.getByteArray}} not deserializable 
for not null array. I planed to deserialize to null for empty array in 
{{SerializedValue.deserializeValue}}. But if callers resort to deserialize 
themselves, then it could be really surprising.

I will go through making value not nullable in {{SerializedValue(T value)}}.

> Missing null value handling for SerializedValue's getByteArray() 
> -----------------------------------------------------------------
>
>                 Key: FLINK-20580
>                 URL: https://issues.apache.org/jira/browse/FLINK-20580
>             Project: Flink
>          Issue Type: Bug
>          Components: API / Type Serialization System
>    Affects Versions: 1.13.0
>            Reporter: Matthias
>            Assignee: Kezhu Wang
>            Priority: Minor
>              Labels: pull-request-available, starter
>
> {{SerializedValue}} allows to wrap {{null}} values. Because of this, 
> {{SerializedValue.getByteArray()}} might return {{null}} which is not 
> properly handled in different locations (it's probably the best to use the 
> IDEs "Find usages" to identify these locations). The most recent findings 
> (for now) are listed in the comments.
> We should add null handling in these cases and add tests for these cases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to