Airblader commented on a change in pull request #15137:
URL: https://github.com/apache/flink/pull/15137#discussion_r592224930
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogBaseTable.java
##########
@@ -18,18 +18,32 @@
package org.apache.flink.table.catalog;
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.table.api.Schema;
import org.apache.flink.table.api.TableSchema;
import org.apache.flink.table.factories.DynamicTableFactory;
import java.util.Map;
import java.util.Optional;
/**
- * CatalogBaseTable is the common parent of table and view. It has a map of
key-value pairs defining
- * the properties of the table.
+ * A common parent that describes the <i>unresolved</i> metadata of a table or
view in a catalog.
+ *
+ * @see CatalogTable
+ * @see CatalogView
*/
+@PublicEvolving
public interface CatalogBaseTable {
+ /** The kind of {@link CatalogBaseTable}. */
+ enum TableKind {
Review comment:
Is "TableKind" the correct abstraction to use if one value is "Table"?
If we e.g. enumerate types of apples, then AppleKind.GRANNY_SMITH is
reasonable, but AppleKind.APPLE sounds out of place. A "table" is not a "kind
of table".
I sort of feel the same way here. `CatalogBaseTable` has that problem, too,
but that class existed already, so we probably can't rename it easily now.
##########
File path:
flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java
##########
@@ -1095,7 +1095,7 @@ public void testTimestampNotNull() {
TestCollectionTableFactory.initData(sourceData);
tEnv().executeSql(
- "CREATE TABLE SourceTable(i INT, ts AS LOCALTIMESTAMP,
WATERMARK FOR ts AS ts) "
+ "CREATE TABLE SourceTable(i INT, ts AS
CAST(LOCALTIMESTAMP AS TIMESTAMP(3)), WATERMARK FOR ts AS ts) "
Review comment:
Is this a drive-by change? Or was this necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
