twalthr commented on a change in pull request #15137:
URL: https://github.com/apache/flink/pull/15137#discussion_r592374833
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogBaseTable.java
##########
@@ -18,18 +18,32 @@
package org.apache.flink.table.catalog;
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.table.api.Schema;
import org.apache.flink.table.api.TableSchema;
import org.apache.flink.table.factories.DynamicTableFactory;
import java.util.Map;
import java.util.Optional;
/**
- * CatalogBaseTable is the common parent of table and view. It has a map of
key-value pairs defining
- * the properties of the table.
+ * A common parent that describes the <i>unresolved</i> metadata of a table or
view in a catalog.
+ *
+ * @see CatalogTable
+ * @see CatalogView
*/
+@PublicEvolving
public interface CatalogBaseTable {
+ /** The kind of {@link CatalogBaseTable}. */
+ enum TableKind {
Review comment:
We were also discussing about the name in the past but couldn't come up
with a better name.
Some background: a view is commonly defined as a `virtual table`. See
https://www.geeksforgeeks.org/sql-views/ or
https://www.w3schools.com/sql/sql_ref_create_view.asp or Wikipedia. So we have
to distinguish between a `real/base table` (= table) or `virtual table`
(=view). The common name is still table unless you have a better idea :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
