rionmonster opened a new pull request #15165:
URL: https://github.com/apache/flink/pull/15165
## What is the purpose of the change
Clean-up for the initialization of the two Prometheus Metric Reporters
(`PrometheusReporter` and `PrometheusPushGatewayReporter`) by explicitly
passing in arguments to the constructors as opposed to relying on resolving
these values via the internal configuration properties.
## Brief change log
- Removed argument resolution against defaults from the `open()` functions
and instead resolved those within the factories and passed them into the
respective reporter instances (roughly modeled after the `JmxReporter`
implementation)
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
