rionmonster edited a comment on pull request #15165: URL: https://github.com/apache/flink/pull/15165#issuecomment-797233206
@zentol / @tillrohrmann I through together what a draft of these changes might look like. It was roughly modeled after the `JmxReporter` implementation which seemed to do something similar (i.e. resolve the port and pass that into the constructor). Since I'm still familiarizing myself with the codebase, I tried to follow conventions that I had seen there (e.g. the use of the `config` suffix for the arguments passed into the constructor), which I wasn't crazy about but kept them in case that was a common convention that I was unaware of. Any feedback or changes? I noticed that after running a `mvn clean verify` per the contribution guide that there were some test failures, but they didn't seem related to these changes (or potentially flaky tests). I have a larger Azure Pipelines build queued as well to run it in a separate environment. Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
