Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1838#discussion_r59232837
  
    --- Diff: 
flink-optimizer/src/test/java/org/apache/flink/optimizer/operators/JoinGlobalPropertiesCompatibilityTest.java
 ---
    @@ -35,7 +37,7 @@ public void checkCompatiblePartitionings() {
                        final FieldList keysLeft = new FieldList(1, 4);
                        final FieldList keysRight = new FieldList(3, 1);
     
    -                   SortMergeInnerJoinDescriptor descr = new 
SortMergeInnerJoinDescriptor(keysLeft, keysRight);
    +                   SortMergeInnerJoinDescriptor descr1 = new 
SortMergeInnerJoinDescriptor(keysLeft, keysRight);
    --- End diff --
    
    why do you rename this variable. I think it can be used for the new tests 
as well, no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to