Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1838#discussion_r59232978
--- Diff:
flink-optimizer/src/test/java/org/apache/flink/optimizer/operators/JoinGlobalPropertiesCompatibilityTest.java
---
@@ -93,7 +95,34 @@ public int partition(Object key, int numPartitions) {
GlobalProperties propsRight = new
GlobalProperties();
propsRight.setCustomPartitioned(keysRight,
part);
- assertTrue(descr.areCompatible(reqLeft,
reqRight, propsLeft, propsRight));
+ assertTrue(descr1.areCompatible(reqLeft,
reqRight, propsLeft, propsRight));
+ }
+
+ TestDistribution dist1 = new TestDistribution(1);
+ TestDistribution dist2 = new TestDistribution(1);
+ SortMergeInnerJoinDescriptor descr2 = new
SortMergeInnerJoinDescriptor(keysLeft, keysRight);
+
+ // test compatible range partitioning
+ {
+ Ordering ordering1 = new Ordering();
+ for (int field : keysLeft) {
+ ordering1.appendOrdering(field, null,
Order.ASCENDING);
+ }
+ Ordering ordering2 = new Ordering();
+ for (int field : keysRight) {
+ ordering2.appendOrdering(field, null,
Order.ASCENDING);
+ }
+
+ RequestedGlobalProperties reqLeft = new
RequestedGlobalProperties();
+ reqLeft.setRangePartitioned(ordering1, dist1);
+ RequestedGlobalProperties reqRigth = new
RequestedGlobalProperties();
--- End diff --
typo: `reqRigth` -> `reqRight`
copy-pasted to the CoGroup test as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
