Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1885#discussion_r59709889 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java --- @@ -81,19 +90,34 @@ public void configure(Configuration parameters) { * @throws IOException */ @Override - public void open(InputSplit ignored) throws IOException { + public void open(InputSplit inputSplit) throws IOException { try { + //TODO is this performed once per Task Manager..? establishConnection(); statement = dbConn.createStatement(resultSetType, resultSetConcurrency); + String query = queryTemplate; + if(isSplitConfigured()){ + RangeInputSplit jdbcInputSplit = (RangeInputSplit) inputSplit; + long start = jdbcInputSplit.getMin(); + long end = jdbcInputSplit.getMax(); + if(isSplitConfigured()){ + query = queryTemplate.replace(CONDITIONS, String.format(BETWEEN, splitColumnName, start, end)); + } + } + LOG.debug(query); resultSet = statement.executeQuery(query); } catch (SQLException se) { - close(); + //close(); already closed by the caller throw new IllegalArgumentException("open() failed." + se.getMessage(), se); } catch (ClassNotFoundException cnfe) { throw new IllegalArgumentException("JDBC-Class not found. - " + cnfe.getMessage(), cnfe); } } + private boolean isSplitConfigured() { + return splitColumnName!=null; --- End diff -- missing spaces around !=
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---