Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1885#discussion_r59711539
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -241,10 +264,31 @@ private void addValue(OUT reuse) throws IOException,
SQLException {
reuse.setField(resultSet.getDouble(pos + 1), pos);
break;
case java.sql.Types.DECIMAL:
-
reuse.setField(resultSet.getBigDecimal(pos + 1).doubleValue(), pos);
- break;
+ //TODO manage null fields
+ try {
+ if (o == null){
+
reuse.setField("", pos);
+ } else{
+
reuse.setField(resultSet.getBigDecimal(pos + 1).toPlainString(), pos);
--- End diff --
this seems inefficient. why not use resultSet.getBigDecimal right away and
then check that fur == null?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
