austince commented on a change in pull request #15348:
URL: https://github.com/apache/flink/pull/15348#discussion_r602553141
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java
##########
@@ -860,6 +902,7 @@ private ExecutionGraph
createExecutionGraphAndRestoreState(JobGraph adjustedJobG
TaskDeploymentDescriptorFactory.PartitionLocationConstraint.MUST_BE_KNOWN,
initializationTimestamp,
vertexAttemptNumberStore,
+ computeVertexParallelismStore(adjustedJobGraph),
Review comment:
Very nice catch, I had not considered how this fits into the declarative
slot pool at all. By using the original-original JobGraph that's passed into
the AdaptiveScheduler to compute the VertexParallelismStore immediately, it
makes it quite easy to integrate into that resource declaration computation. I
just had to use the newly created parallelism store as the source of truth in
JobGraphJobInformation's parallelism reporting. 👍🏼 Thanks very much Chesnay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
