austince commented on a change in pull request #15348:
URL: https://github.com/apache/flink/pull/15348#discussion_r602590455



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java
##########
@@ -860,6 +902,7 @@ private ExecutionGraph 
createExecutionGraphAndRestoreState(JobGraph adjustedJobG
                 
TaskDeploymentDescriptorFactory.PartitionLocationConstraint.MUST_BE_KNOWN,
                 initializationTimestamp,
                 vertexAttemptNumberStore,
+                computeVertexParallelismStore(adjustedJobGraph),

Review comment:
       This was easy to integrate, but it might show some issues with the 
`SlotSharingSlotAllocator#tryReserveResources` method – I'm not entirely sure 
where they lie/ if it is actually an issue with the parallelism assignment. It 
could also be an issue with the testing setups in AdaptiveSchedulerTest, which 
make some assumptions about parallelism. Investigating...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to