Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1838#issuecomment-211923989
  
    Hi @gallenvara, thanks for the update! I tried it locally and it worked as 
expected. 
    
    I would like two more test methods though, to ensure that the thing is 
working end-to-end.
    Could you add one test method to `JoinITCase` which basically extends 
`testeUDFJoinOnTuplesWithMultipleKeyFieldPositions()` and uses range 
partitioning. For that you should provide a DataDistribution and set the 
parallelism to 4 on the environment. 
    Please to the same with 
`CoGroupITCase.testCoGroupWithMultipleKeyFieldsWithFieldSelector()`
    
    After that we can merge the PR. Thanks, Fabian


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to