Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1838#issuecomment-212402787
Hi @gallenvara, the tests look good. I left a few comments to make the test
code more concise.
Regarding your questions:
1) Yes, we could change the `Object[]` to Tuple. However, I am not sure if
this would confuse users. Tuple is usually used as a data type in programs
while in DataDistribution it would be a holder for composite keys.
2) The problem with returning `Tuple` from a `KeySelector` is that `Tuple`
does not implement `Comparable` as requested by `partitionByHash` or
`partitionByRange`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
