[
https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247751#comment-15247751
]
ASF GitHub Bot commented on FLINK-2998:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1838#issuecomment-211923989
Hi @gallenvara, thanks for the update! I tried it locally and it worked as
expected.
I would like two more test methods though, to ensure that the thing is
working end-to-end.
Could you add one test method to `JoinITCase` which basically extends
`testeUDFJoinOnTuplesWithMultipleKeyFieldPositions()` and uses range
partitioning. For that you should provide a DataDistribution and set the
parallelism to 4 on the environment.
Please to the same with
`CoGroupITCase.testCoGroupWithMultipleKeyFieldsWithFieldSelector()`
After that we can merge the PR. Thanks, Fabian
> Support range partition comparison for multi input nodes.
> ---------------------------------------------------------
>
> Key: FLINK-2998
> URL: https://issues.apache.org/jira/browse/FLINK-2998
> Project: Flink
> Issue Type: New Feature
> Components: Optimizer
> Reporter: Chengxiang Li
> Priority: Minor
>
> The optimizer may have potential opportunity to optimize the DAG while it
> found two input range partition are equivalent, we does not support the
> comparison yet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
