[
https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249747#comment-15249747
]
ASF GitHub Bot commented on FLINK-2998:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1838#issuecomment-212402787
Hi @gallenvara, the tests look good. I left a few comments to make the test
code more concise.
Regarding your questions:
1) Yes, we could change the `Object[]` to Tuple. However, I am not sure if
this would confuse users. Tuple is usually used as a data type in programs
while in DataDistribution it would be a holder for composite keys.
2) The problem with returning `Tuple` from a `KeySelector` is that `Tuple`
does not implement `Comparable` as requested by `partitionByHash` or
`partitionByRange`.
> Support range partition comparison for multi input nodes.
> ---------------------------------------------------------
>
> Key: FLINK-2998
> URL: https://issues.apache.org/jira/browse/FLINK-2998
> Project: Flink
> Issue Type: New Feature
> Components: Optimizer
> Reporter: Chengxiang Li
> Priority: Minor
>
> The optimizer may have potential opportunity to optimize the DAG while it
> found two input range partition are equivalent, we does not support the
> comparison yet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
