wuchong commented on a change in pull request #15660:
URL: https://github.com/apache/flink/pull/15660#discussion_r618045219
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectITCase.java
##########
@@ -255,6 +255,20 @@ public void testCreateTable() throws Exception {
tableEnv.executeSql("create table if not exists tbl5 (m
map<bigint,string>)");
hiveTable = hiveCatalog.getHiveTable(new ObjectPath("default",
"tbl5"));
assertEquals(createdTimeForTableExists, hiveTable.getCreateTime());
+
+ // test describe table
+ assertEquals(
+ 3,
+ CollectionUtil.iteratorToList(tableEnv.executeSql("desc
tbl1").collect()).size());
+ assertEquals(
+ 1,
+ CollectionUtil.iteratorToList(tableEnv.executeSql("describe
tbl2").collect())
+ .size());
+ assertEquals(
+ 3,
+ CollectionUtil.iteratorToList(
Review comment:
For Flink dialect, we test the describe result in
`flink-table/flink-sql-client/src/test/resources/sql/table.q`.
Is it possible to test this feature in
`flink-connectors/flink-connector-hive/src/test/resources/query-test`?
If this needs some refactoring, I'm fine with merging this fix first to not
block the release, and we can do that in a follow-up PR.
Maybe we can move hive dialect tests to sql-client to reuse the script
testing framework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
