lirui-apache commented on a change in pull request #15660:
URL: https://github.com/apache/flink/pull/15660#discussion_r618052517
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectITCase.java
##########
@@ -255,6 +255,20 @@ public void testCreateTable() throws Exception {
tableEnv.executeSql("create table if not exists tbl5 (m
map<bigint,string>)");
hiveTable = hiveCatalog.getHiveTable(new ObjectPath("default",
"tbl5"));
assertEquals(createdTimeForTableExists, hiveTable.getCreateTime());
+
+ // test describe table
+ assertEquals(
+ 3,
+ CollectionUtil.iteratorToList(tableEnv.executeSql("desc
tbl1").collect()).size());
+ assertEquals(
+ 1,
+ CollectionUtil.iteratorToList(tableEnv.executeSql("describe
tbl2").collect())
+ .size());
+ assertEquals(
+ 3,
+ CollectionUtil.iteratorToList(
Review comment:
We can compare the result in this test. But my point is it's
`TableEnvironmentImpl` that decides what's the result looks like. Verifying
something hive dialect can't control in a hive dialect test doesn't make much
sense. From hive dialect perspective, anything returned from
`TableEnvironmentImpl` would be considered legitimate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
