[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278160#comment-15278160
]
ASF GitHub Bot commented on FLINK-3754:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1958#discussion_r62680102
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/TableEnvironment.scala
---
@@ -197,6 +209,17 @@ abstract class TableEnvironment(val config:
TableConfig) {
planner
}
+ /**
+ * Returns the Calcite
[[org.apache.calcite.rel.`type`.RelDataTypeFactory]]
+ * of this TableEnvironment. */
+ private[flink] def getTypeFactory: RelDataTypeFactory = {
--- End diff --
`getTypeFactory()` and `getTable()` are only called to create a
`CatalogNode` which internally obtains the `rowType: RelDataType` of the table.
I think we can simply return the `rowType` for a given table name and remove
`getTypeFactory()` and `getTable()` from this class.
> Add a validation phase before construct RelNode using TableAPI
> --------------------------------------------------------------
>
> Key: FLINK-3754
> URL: https://issues.apache.org/jira/browse/FLINK-3754
> Project: Flink
> Issue Type: Improvement
> Components: Table API
> Affects Versions: 1.0.0
> Reporter: Yijie Shen
> Assignee: Yijie Shen
>
> Unlike sql string's execution, which have a separate validation phase before
> RelNode construction, Table API lacks the counterparts and the validation is
> scattered in many places.
> I suggest to add a single validation phase and detect problems as early as
> possible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
