[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278183#comment-15278183
]
ASF GitHub Bot commented on FLINK-3754:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1958#discussion_r62682327
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/logic.scala
---
@@ -21,25 +21,47 @@ import org.apache.calcite.rex.RexNode
import org.apache.calcite.sql.fun.SqlStdOperatorTable
import org.apache.calcite.tools.RelBuilder
-abstract class BinaryPredicate extends BinaryExpression { self: Product =>
}
+import org.apache.flink.api.common.typeinfo.BasicTypeInfo
+import org.apache.flink.api.table.validate.ExprValidationResult
+
+abstract class BinaryPredicate extends BinaryExpression {
+ override def dataType = BasicTypeInfo.BOOLEAN_TYPE_INFO
+
+ override def validateInput(): ExprValidationResult = {
+ if (left.dataType == BasicTypeInfo.BOOLEAN_TYPE_INFO &&
+ right.dataType == BasicTypeInfo.BOOLEAN_TYPE_INFO) {
+ ExprValidationResult.ValidationSuccess
+ } else {
+ ExprValidationResult.ValidationFailure(s"$this only accept child of
Boolean Type, " +
--- End diff --
Please change to `"$this only accepts children of Boolean type"`
> Add a validation phase before construct RelNode using TableAPI
> --------------------------------------------------------------
>
> Key: FLINK-3754
> URL: https://issues.apache.org/jira/browse/FLINK-3754
> Project: Flink
> Issue Type: Improvement
> Components: Table API
> Affects Versions: 1.0.0
> Reporter: Yijie Shen
> Assignee: Yijie Shen
>
> Unlike sql string's execution, which have a separate validation phase before
> RelNode construction, Table API lacks the counterparts and the validation is
> scattered in many places.
> I suggest to add a single validation phase and detect problems as early as
> possible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
