GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1978
[FLINK-3667] refactor client communication
This is mainly an effort to refactor the client side of the cluster
instantiation and communication. This pull request moves around many things
which were already in place but, hopefully, makes it easier and more explicit
for new cluster clients/frameworks to interface.
The main changes:
Client
- `Client` becomes the abstract base class for client<->cluster
communication
- It enforces a stricter life cycle for cluster communication via abstract
methods that clients need to implement
- It shares resources, e.g. ActorSystem with the subclassed clients
Yarn
- All Yarn dependencies have been moved to `flink-yarn`
- The Yarn client (`YarnClusterClient`) has been refactored as subclass of
the `Client` class
- Yarn specific configuration (`YarnClusterDescriptor`) has been
implemented as subclass of the `ClusterDescriptor`
CliFrontend
- `CliFrontend` interfaces with custom command-line parsers via the
`CustomCommandLine` interface
- `CliFrontend` doesn't use any special logic for Yarn
Other
- A few bug fixes regarding the `ApplicationClient` communication
------
- [X] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [X] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [X] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-3667
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1978.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1978
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
