[GitHub] flink pull request: [FLINK-3667] refactor client communication

[rmetzger]

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1978#discussion_r63678293
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
    @@ -65,31 +73,25 @@
     /**
      * Encapsulates the functionality necessary to submit a program to a 
remote cluster.
      */
    -public class Client {
    +public abstract class Client {
    --- End diff --
    
    I wonder if we can rid of some of the overloaded methods here.
    
    For example
    ```
    public JobGraph getJobGraph(PackagedProgram prog, FlinkPlan optPlan) throws 
ProgramInvocationException
    public JobGraph getJobGraph(PackagedProgram prog, FlinkPlan optPlan, String 
savepointPath) throws ProgramInvocationException
    ```
    
    seem both unused (on first sight, not sure).
    
    
![image](https://cloud.githubusercontent.com/assets/89049/15355314/301e8e9a-1cf2-11e6-84ef-592609320f9f.png)
    
    
    Ideally we have one runBlocking, one runDetached and one plan optimization. 
I'm not sure if its really necessary to have so many variants ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---