[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278512#comment-15278512
]
ASF GitHub Bot commented on FLINK-3754:
---------------------------------------
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1958#discussion_r62715347
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/StreamTableEnvironment.scala
---
@@ -92,8 +93,7 @@ abstract class StreamTableEnvironment(
def ingest(tableName: String): Table = {
if (isRegistered(tableName)) {
- relBuilder.scan(tableName)
- new Table(relBuilder.build(), this)
+ new Table(this, CatalogNode(tableName, getTable(tableName),
getTypeFactory))
}
else {
throw new TableException(s"Table \'$tableName\' was not found in the
registry.")
--- End diff --
As we discussed
https://github.com/apache/flink/pull/1958#discussion_r62680699 , we should keep
this TableException?
> Add a validation phase before construct RelNode using TableAPI
> --------------------------------------------------------------
>
> Key: FLINK-3754
> URL: https://issues.apache.org/jira/browse/FLINK-3754
> Project: Flink
> Issue Type: Improvement
> Components: Table API
> Affects Versions: 1.0.0
> Reporter: Yijie Shen
> Assignee: Yijie Shen
>
> Unlike sql string's execution, which have a separate validation phase before
> RelNode construction, Table API lacks the counterparts and the validation is
> scattered in many places.
> I suggest to add a single validation phase and detect problems as early as
> possible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
