[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278792#comment-15278792
]
ASF GitHub Bot commented on FLINK-3754:
---------------------------------------
Github user yjshen commented on the pull request:
https://github.com/apache/flink/pull/1958#issuecomment-218278581
Hi @fhueske, part of the comments are resolved and updated, two TODOs:
- [ ] Type coercion for expressions, for example:
- `Add(int, long)` should be auto coerced to `Add(cast(long), long)`
- expressions expecting `double` as input but get `int` such as
`ln(int)` should be auto cast to `ln (cast(double))`
- [ ] `TreeNode`, `FunctionCatalog` etc rewrite.
> Add a validation phase before construct RelNode using TableAPI
> --------------------------------------------------------------
>
> Key: FLINK-3754
> URL: https://issues.apache.org/jira/browse/FLINK-3754
> Project: Flink
> Issue Type: Improvement
> Components: Table API
> Affects Versions: 1.0.0
> Reporter: Yijie Shen
> Assignee: Yijie Shen
>
> Unlike sql string's execution, which have a separate validation phase before
> RelNode construction, Table API lacks the counterparts and the validation is
> scattered in many places.
> I suggest to add a single validation phase and detect problems as early as
> possible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
