XComp commented on a change in pull request #16286:
URL: https://github.com/apache/flink/pull/16286#discussion_r662129429
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/program/PackagedProgramRetrieverImplTest.java
##########
@@ -197,8 +197,8 @@ public void
testDeriveEntryClassInformationFromClasspathWithJobClass()
PackagedProgramRetrieverImpl.createEntryClassInformationProvider(
// the user directory must be specified
multipleEntryClassesClasspathProvider.getDirectory(),
- // the user classpath is derived from the user
directory outside of the
- // method
+ // the user classpath is derived from the user
directory outside of
+ // createEntryClassInformationProvider
Review comment:
I find it a bit confusing to pass in the user directory and the user
classpath. But this was required to match the original functionality. That's
why I added the comment to make it obvious that the user classpath and the user
directory are actually referring to the same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
