zhuzhurk commented on a change in pull request #16679:
URL: https://github.com/apache/flink/pull/16679#discussion_r681668364
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/BatchShuffleMode.java
##########
@@ -41,7 +41,7 @@
* to run upstream and downstream tasks simultaneously.
*/
@PublicEvolving
-public enum ShuffleMode implements DescribedEnum {
+public enum BatchShuffleMode implements DescribedEnum {
Review comment:
> The shuffle mode depends on the configured {@link
ExecutionOptions#RUNTIME_MODE}
This seems to be outdated.
> is only relevant for batch executions on bounded streams.
I do not quite understand what it. Could you explain it a bit more?
> I would leave the more extensive class JavaDoc to understand the meaning
of BatchShuffleMode in general and why it doesn't apply to streaming mode.
I agree the more extensive class JavaDoc is good. But currently it says that
streaming mode uses pipelined and batch mode uses blocking, which is actually
against the goal that we want shuffle mode of batch mode to be configurable.
For example, maybe we can change "In streaming mode" to "With pipelined
exchanges", and later say that streaming job always uses this exchange and
batch job can also use it to achieve low latency or higher throughput.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
