zhuzhurk commented on a change in pull request #16679:
URL: https://github.com/apache/flink/pull/16679#discussion_r681877463
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/BatchShuffleMode.java
##########
@@ -41,7 +41,7 @@
* to run upstream and downstream tasks simultaneously.
*/
@PublicEvolving
-public enum ShuffleMode implements DescribedEnum {
+public enum BatchShuffleMode implements DescribedEnum {
Review comment:
Thanks for the update. It now looks generally good to me, except for the
part for "low latency" and "higher throughput".
When saying "low latency" and "higher throughput" in my last comment, I
actually means the benefit of pipelined exchanges. Latency does not make much
sense for batch jobs so I used "higher throughput" instead.
I think we can simply remove "Batch jobs can be configured for lower latency
or higher throughput" and "In order to achieve higher throughput".
Sorry for the confusion caused by my words.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
