Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2049#discussion_r66762005 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/MaxAggregate.scala --- @@ -48,8 +57,16 @@ abstract class MaxAggregate[T](implicit ord: Ordering[T]) extends Aggregate[T] { override def merge(intermediate: Row, buffer: Row): Unit = { --- End diff -- I think we can make this method a bit more efficient: ``` val partialValue = ... if (partialValue != null) { val bufferValue = ... if (bufferValue != null) { val max = ... buffer.setField(maxIndex, max) } else { buffer.setField(maxIndex, partialValue) } } ``` Same applies for `MinAggregate` and `SumAggregate`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---