Github user gallenvara commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2049#discussion_r66765029
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/MaxAggregate.scala
 ---
    @@ -48,8 +57,16 @@ abstract class MaxAggregate[T](implicit ord: 
Ordering[T]) extends Aggregate[T] {
       override def merge(intermediate: Row, buffer: Row): Unit = {
    --- End diff --
    
    Yes, you are right. The cases where `partialValue == null` should be 
ignored directly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to