akalash commented on a change in pull request #16637:
URL: https://github.com/apache/flink/pull/16637#discussion_r686157796
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointFailureManager.java
##########
@@ -136,6 +135,8 @@ public void checkFailureCounter(CheckpointException
exception, long checkpointId
// ignore
break;
+ case EXCEPTION:
Review comment:
It, of course, appears in the logs somewhere(at least in stack trace but
I don't see explicit printing of `CheckpointFailureReason`) but if we take into
account that this PR split existing one `CheckpointFailureReason` into two
which in any case changes the previous behavior I still think that it will be
ok to rename it. And yes, the message will be slightly different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
