akalash commented on a change in pull request #16637:
URL: https://github.com/apache/flink/pull/16637#discussion_r687554740
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointFailureManager.java
##########
@@ -127,7 +127,6 @@ public void checkFailureCounter(CheckpointException
exception, long checkpointId
case CHECKPOINT_DECLINED_SUBSUMED:
case CHECKPOINT_DECLINED_INPUT_END_OF_STREAM:
- case EXCEPTION:
Review comment:
It is ok to have two separate commits under one jira ticket. You can
check the git log and see that it is the pretty usual stuff. It makes sense to
do so when you have tightly connected changes but they are still logically
different and for example, they require different commit names. So it is
exactly your case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
