dmvk commented on a change in pull request #16652:
URL: https://github.com/apache/flink/pull/16652#discussion_r686704995
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/CheckpointStoreITCase.java
##########
@@ -126,68 +147,39 @@ public HighAvailabilityServices createHAServices(
@Override
public CheckpointRecoveryFactory
getCheckpointRecoveryFactory() {
Review comment:
Not without implementing proper cleanup of leader election services for
`TestingHighAvailabilityServices` (otherwise I'll end up with something like
`Caused by: java.lang.IllegalStateException: leader retrieval service is
already started`).
I think implementing this would basically lead to re-implemention of
`EmbeddedHaServices` for purpose of this test.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
