dmvk commented on a change in pull request #16652:
URL: https://github.com/apache/flink/pull/16652#discussion_r686767953
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/EmbeddedCompletedCheckpointStore.java
##########
@@ -35,23 +36,24 @@
private final ArrayDeque<CompletedCheckpoint> checkpoints = new
ArrayDeque<>(2);
- private final Collection<CompletedCheckpoint> suspended = new
ArrayDeque<>(2);
+ private final Collection<CompletedCheckpoint> suspended =
+ Collections.synchronizedList(new ArrayList<>());
Review comment:
This is the reason, we've changed signature of function that constructs
checkpoint store in `PerJobCheckpointRecoveryFactory` to `(maxCheckpoints,
previous)`, to obtain access to previous (already shutdown) instance of
checkpoint store, if there was any
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/EmbeddedCompletedCheckpointStore.java
##########
@@ -35,23 +36,24 @@
private final ArrayDeque<CompletedCheckpoint> checkpoints = new
ArrayDeque<>(2);
- private final Collection<CompletedCheckpoint> suspended = new
ArrayDeque<>(2);
+ private final Collection<CompletedCheckpoint> suspended =
+ Collections.synchronizedList(new ArrayList<>());
Review comment:
This is also a reason, we've changed signature of function that
constructs checkpoint store in `PerJobCheckpointRecoveryFactory` to
`(maxCheckpoints, previous)`, to obtain access to previous (already shutdown)
instance of checkpoint store, if there was any
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
