rkhachatryan commented on a change in pull request #16773: URL: https://github.com/apache/flink/pull/16773#discussion_r688929533
########## File path: flink-tests/src/test/java/org/apache/flink/runtime/operators/lifecycle/event/TestEventQueue.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.operators.lifecycle.event; + +import org.apache.flink.testutils.junit.SharedObjects; + +import java.io.Serializable; +import java.util.List; + +/** A queue for {@link TestEvent}. */ +public interface TestEventQueue extends Serializable { Review comment: `SharedReference` is needed to solve serializability issues, not concurrency issues. This is one responsibility. The other one is to notify listeners about events and manage both. The simplification you mentioned is about removing other interfaces inside the `TestEventQueueImpl`, not about `SharedReference`. Besides that, I don't think LoC is a very useful metric. Complexity IMO actually comes from mixing concerns, not lines of code. I totally agree that the **internals** of `TestEventQueueImpl` should be simplified (those parts are some leftovers after changing the logic and refactoring , sorry about that). I added 77ec66446aa2a3dbe2b535bd3df84df2fb8d5b48 to address that, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
