rkhachatryan commented on a change in pull request #16773: URL: https://github.com/apache/flink/pull/16773#discussion_r688933981
########## File path: flink-tests/src/test/java/org/apache/flink/runtime/operators/lifecycle/command/TestCommandQueue.java ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.operators.lifecycle.command; + +import org.apache.flink.testutils.junit.SharedObjects; + +import java.io.Serializable; + +/** A queue for {@link TestCommand} executed by operators in a test job. */ +public interface TestCommandQueue extends Serializable { + + void add(TestCommand testCommand, TestCommandTarget target, TestCommandRetention retention); Review comment: > What is the price that we would be pay by having two methods instead of one? > Further inlining (somehting like sendSingleSubtaskCommand) would prevent fluent interface. Without the latter, there will be branching logic like ``` if (fullyFinish) { sendToAllSubtasksOfAllTasks } else { sendToSingleSubtaskOfAllTasks } // next step ``` I'd create these methods though if you insist. The reduction of number of jumps obiously comes from merging the two classes + interface into one. They are are split for the [same reason as](https://github.com/apache/flink/pull/16773#discussion_r688929533) SharedTestEventQueue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
