NicoK commented on a change in pull request #16964:
URL: https://github.com/apache/flink/pull/16964#discussion_r697373957
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.java
##########
@@ -61,7 +61,9 @@
public DBOptions createDBOptions(Collection<AutoCloseable>
handlesToClose) {
return new DBOptions()
.setUseFsync(false)
- .setInfoLogLevel(InfoLogLevel.HEADER_LEVEL)
+ .setInfoLogLevel(InfoLogLevel.INFO_LEVEL)
+ .setMaxLogFileSize(DEFAULT_LOG_FILE_SIZE)
+ .setKeepLogFileNum(DEFAULT_LOG_FILE_NUM)
Review comment:
But with this PR, the log file size and number also have (implicit)
defaults that the profiles in `PredefinedOptions` set...
I'd rather prefer to make things clear right away, otherwise, there's a
(high) chance that this could not happen (you can see that pretty well with
documentation not being updated when features are added).
I don't think we need to rush anything with this PR - you can already
configure the log level via configuration, so changing the defaults doesn't
have to come with 1.14!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
