Myasuka commented on a change in pull request #16964:
URL: https://github.com/apache/flink/pull/16964#discussion_r698151241
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.java
##########
@@ -61,7 +61,9 @@
public DBOptions createDBOptions(Collection<AutoCloseable>
handlesToClose) {
return new DBOptions()
.setUseFsync(false)
- .setInfoLogLevel(InfoLogLevel.HEADER_LEVEL)
+ .setInfoLogLevel(InfoLogLevel.INFO_LEVEL)
+ .setMaxLogFileSize(DEFAULT_LOG_FILE_SIZE)
+ .setKeepLogFileNum(DEFAULT_LOG_FILE_NUM)
Review comment:
@NicoK Thanks for your feedback, after discussion with @carp84 offline,
I decide to hold this PR currently and create another ticket
https://issues.apache.org/jira/browse/FLINK-24046 to track the refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
