[ 
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344351#comment-15344351
 ] 

ASF GitHub Bot commented on FLINK-1550:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2146#discussion_r68059122
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
 ---
    @@ -149,6 +154,9 @@ class JobManager(
     
       var leaderSessionID: Option[UUID] = None
     
    +  private var metricsRegistry : FlinkMetricRegistry = _
    +  private var jobManagerMetricGroup : JobManagerMetricGroup = _
    --- End diff --
    
    We could maybe create the `JobManagerMetricGroup` directly in the 
constructor of the `JobManager` if we pass in the `FlinkMetricRegistry` as a 
constructor argument.


> Show JVM Metrics for JobManager
> -------------------------------
>
>                 Key: FLINK-1550
>                 URL: https://issues.apache.org/jira/browse/FLINK-1550
>             Project: Flink
>          Issue Type: Sub-task
>          Components: JobManager, Metrics
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>             Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to