[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344393#comment-15344393
]
ASF GitHub Bot commented on FLINK-1550:
---------------------------------------
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2146
Really good work @zentol. I had some minor comments concerning the
instantiation of the `MetricRegistry` for the `JobManager` and some
clarifications. I think it would be good if we could add some test cases which
check, for example, that we report the correct checkpoint size and duration.
Maybe you could also rebase this PR on the referred PR #2145. Then it would
be easier to test the job manager metrics on a local machine. I would like to
do it before merging. But once this is done, then I think we're good to merge
your PR :-)
> Show JVM Metrics for JobManager
> -------------------------------
>
> Key: FLINK-1550
> URL: https://issues.apache.org/jira/browse/FLINK-1550
> Project: Flink
> Issue Type: Sub-task
> Components: JobManager, Metrics
> Reporter: Robert Metzger
> Assignee: Chesnay Schepler
> Fix For: pre-apache
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
